Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INVS-1778: Request custom target column names to determine match list state when appropriate #591

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

bgrey-sumo
Copy link
Collaborator

Because the API returns the custom column ID instead of the custom column name in the target_column value, if the TF user creates a match list using a custom column name (which is allowed by the API), it detects that the match list is constantly out of sync and needs to update the state.

This change utilizes a new query parameter that allows the caller to request that the custom column name be returned instead of the ID when looking up a match list.

@pmontiel-sumo
Copy link
Collaborator

@bgrey-sumo don't forget to update CHANGELOG.md

@bgrey-sumo
Copy link
Collaborator Author

@bgrey-sumo don't forget to update CHANGELOG.md

Thank you sir. I think this is the way I'm supposed to update it but let me know otherwise.

@bgrey-sumo bgrey-sumo merged commit e41f6cb into master Nov 14, 2023
3 checks passed
@bgrey-sumo bgrey-sumo deleted the bg/invs-1778 branch November 14, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants