Fixed getSoftMenuBarHeight() not returning the right value on notched…

… devices (#50)
Sunhat · Apr 2, 2019 · c41652e · c41652e
1 parent da3e749
commit c41652e
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/android/src/main/java/ca/jaysoo/extradimensions/ExtraDimensionsModule.java b/android/src/main/java/ca/jaysoo/extradimensions/ExtraDimensionsModule.java
@@ -103,16 +103,12 @@ private float getSoftMenuBarHeight(DisplayMetrics metrics) {
         if(hasPermanentMenuKey()) {
             return 0;
         }
-        final float realHeight = getRealHeight(metrics);
         final Context ctx = getReactApplicationContext();
-        final DisplayMetrics usableMetrics = ctx.getResources().getDisplayMetrics();
-
-        // Passing getMetrics will update the value of the Object DisplayMetrics metrics
-        ((WindowManager) mReactContext.getSystemService(Context.WINDOW_SERVICE))
-                .getDefaultDisplay().getMetrics(metrics);
-        final int usableHeight = usableMetrics.heightPixels;
-
-        return Math.max(0, realHeight - usableHeight / metrics.density);
+        final int heightResId = ctx.getResources().getIdentifier("navigation_bar_height", "dimen", "android");
+        return
+          heightResId > 0
+            ? ctx.getResources().getDimensionPixelSize(heightResId) / metrics.density
+            : 0;
     }
 
     private float getRealHeight(DisplayMetrics metrics) {