For the fix of hasPermanentMenuKey #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gongdao123 Can you explain what these changes achieve and why you had to "revert back" ? Thanks! |
|
@gongdao123 Please explain |
|
Could you please merge this |
|
Is there any reason not to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in this link:
https://www.jianshu.com/p/e164dec92bd8
The soft menu key (also known as Action Bar) is not only controlled by:
config_showNavigationBarbut also:
qemu.hw.mainkeysThe previous code will cause Softmenu Bar height always be 0 in the simulator.