Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decrease reader's up and down arrows scrolling distance #588

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

JiPaix
Copy link
Contributor

@JiPaix JiPaix commented Jan 30, 2024

The up and down arrow keys now function similarly to the left and right arrows; they scroll the reader to a specific image/position. Whereas previously, the up and down arrows provided more control, allowing for scrolling only a few pixels at a time (a native browser function).

This change might appear subjective, but the previous behavior provided greater control.

Partially revert PR #452.

@schroda
Copy link
Collaborator

schroda commented Jan 30, 2024

I'd prefer to keep the control of the buttons, so how about decreasing the scroll amount for the up and down arrow keys?

@JiPaix JiPaix changed the title revert reader's up and down arrows keys behavior ~revert~ change reader's up and down arrows keys ~behavior~ scrolling distance Feb 1, 2024
@JiPaix JiPaix changed the title ~revert~ change reader's up and down arrows keys ~behavior~ scrolling distance revert reader's up and down arrows keys behavior Feb 1, 2024
src/components/reader/pager/VerticalPager.tsx Outdated Show resolved Hide resolved
src/components/reader/pager/VerticalPager.tsx Outdated Show resolved Hide resolved
src/components/reader/pager/VerticalPager.tsx Outdated Show resolved Hide resolved
src/components/reader/pager/VerticalPager.tsx Outdated Show resolved Hide resolved
@JiPaix JiPaix changed the title revert reader's up and down arrows keys behavior decrease reader's up and down arrows scrolling distance Feb 1, 2024
@JiPaix JiPaix requested a review from schroda February 1, 2024 17:09
@schroda schroda merged commit 7fb1dae into Suwayomi:master Feb 1, 2024
1 check passed
@JiPaix JiPaix deleted the patch-1 branch February 1, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants