Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All day event doesn't disappear after changing the week #178

Closed
1 task done
tyler-dane opened this issue Dec 9, 2024 · 4 comments · Fixed by #185
Closed
1 task done

All day event doesn't disappear after changing the week #178

tyler-dane opened this issue Dec 9, 2024 · 4 comments · Fixed by #185
Assignees

Comments

@tyler-dane
Copy link
Contributor

tyler-dane commented Dec 9, 2024

Prerequisites

  • Using an up-to-date main branch

Expected Behavior

Given that there is an all-day event
and the event's form is open
and a user changes the start and end dates
and those start and end dates are both in a new week
and the user clicks Save
then the all-day event rectangle should disappear from the screen
and the event should be visible when navigating to the correct week.

Current Behavior

After saving the event, the rectangle still appears in the current week view.

This is happening for both new and existing events

Steps to Reproduce

  1. Click the all-day row to create an all-day event (or click an existing all-day event)
  2. Click the start date picker and assign the event to a new week. For example, if today is 12/9/2024, and the week in view is 12/8/24 - 12/14/24, then make the new start 12/17/24 (the next week)
  3. Repeat for the end date
  4. Click save
  5. Notice: the event rectangle doesn't disappear
  6. Refresh page
  7. Notice: the event rectangle is gone now (due to re-fetching data during page load)
bugdemo.mov

Possible Solution (Not obligatory)

Consider adding a redux action that updates the draft state. Try to avoid adding lots of effects to the DraftEvent, which is already getting overly complex.

Also remember to make the solution work for both new and existing all-day events.

Context

This bug makes users less confident in Compass and its ability to do the basic task of rescheduling events.

@murilo9
Copy link
Contributor

murilo9 commented Dec 9, 2024

I will give a look on this.

@murilo9
Copy link
Contributor

murilo9 commented Dec 9, 2024

Obs: when I click outside the date picker after selecting a start/end date, I get the same error message reported in #171
Update: just pulled from main branch and the error message doesn't show up anymore.

@tyler-dane tyler-dane moved this from Ready to In progress in 🏗 Compass Roadmap Dec 10, 2024
@tyler-dane tyler-dane changed the title All day event doesn't disappear after reassigning weeks All day event doesn't disappear after changing the week Dec 10, 2024
@tyler-dane
Copy link
Contributor Author

Obs: when I click outside the date picker after selecting a start/end date, I get the same error message reported in #171 Update: just pulled from main branch and the error message doesn't show up anymore.

Glad to hear that message isn't showing up anymore. Left a comment in that issue on how to track that error going forward.

I'm going to assume you're not blocked on this anymore and are still chipping away at it, but LMK if you need anything else.

@murilo9
Copy link
Contributor

murilo9 commented Dec 10, 2024

Solved the issue, but also have some bad news: I'm getting the error message mentioned in #171 again: when I open the DatePicker and click outside of it, and when clicking the arrow buttons :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment