🐛 Fix: All day event doesn't disappear after changing the week - Attempt #2

[murilo9]

This is a better, non-style-level fix for #178

As you suggested, I've added some logic into useDraftUtil.ts:submit to check if the updated event will be rendered inside current view. If not, it marks the event to be removed from the store after the update. Now once we save an event with dates for a different week, it immediately disapers from the screen.

All automated tests have passed.

However, the "flicking" event with full width still persists for some milliseconds once you change weeks. I'm not sure yet what is the cause of this, but I will let the PR open while I give a look on this.

[tyler-dane]

"However, the "flicking" event with full width still persists for some milliseconds once you change weeks. I'm not sure yet what is the cause of this, but I will let the PR open while I give a look on this."

Can you provide steps to replicate this?

Are you referring to the sidebar's re-rending (including the loading spinner)? If so, that's a known and unrelated issue. If it's something else related to the main-grid, then I'd like to replicate it before merging this

[tyler-dane]

This is much better so far.

Would like more clarification on the flickering you mentioned before QA-ing further.

[murilo9]

How to reproduce the "flickering" event bug:

1. Add an all-day event in a different week.
2. Move the view to that week, so you can see the all-day event. It should render properly.
3. Move back to the previous week, you'll note that an all-day event with the duration of the whole view quickly shows (for less than a second) then disappears.

I'm not sure what is causing that but I suspect it might be something to do with the order of the steps in editEvent saga.

Update: my suspiction is that when we change the current week, CalendarView re-renders, triggering re-renders in all its component tree until reaching AllDayEvents component, so only then AllDayEvents re-calculates the correct value of its allDayEvents variable in order to display the new week's events. As that series of re-renders take some milliseconds to complete, we still see the old events very briefly. I've tried moving the allDayEvents variable to CalendarView and prop drill it down to the AllDayEvents component, but the flicking persists. I'm out of ideas on how to solve that now =(

[tyler-dane]

Thanks for including the detailed steps to reproduce it. Since that behavior exists in main now, we don't need to block this PR. I create a new bug to address it in the future: #186

Doing a little more QA on this one, but it's in pretty good shape. Please feel free to continue working on your other issue while I continue testing/tweaking