-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All day event doesn't disappear after changing the week #178
Comments
I will give a look on this. |
Obs: when I click outside the date picker after selecting a start/end date, I get the same error message reported in #171 |
Glad to hear that message isn't showing up anymore. Left a comment in that issue on how to track that error going forward. I'm going to assume you're not blocked on this anymore and are still chipping away at it, but LMK if you need anything else. |
Solved the issue, but also have some bad news: I'm getting the error message mentioned in #171 again: when I open the DatePicker and click outside of it, and when clicking the arrow buttons :( |
Prerequisites
Expected Behavior
Given that there is an all-day event
and the event's form is open
and a user changes the start and end dates
and those start and end dates are both in a new week
and the user clicks Save
then the all-day event rectangle should disappear from the screen
and the event should be visible when navigating to the correct week.
Current Behavior
After saving the event, the rectangle still appears in the current week view.
This is happening for both new and existing events
Steps to Reproduce
bugdemo.mov
Possible Solution (Not obligatory)
Consider adding a redux action that updates the draft state. Try to avoid adding lots of effects to the
DraftEvent
, which is already getting overly complex.Also remember to make the solution work for both new and existing all-day events.
Context
This bug makes users less confident in Compass and its ability to do the basic task of rescheduling events.
The text was updated successfully, but these errors were encountered: