Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event can still be changed during optimistic render #201

Closed
tyler-dane opened this issue Dec 25, 2024 · 1 comment · Fixed by #206
Closed

Event can still be changed during optimistic render #201

tyler-dane opened this issue Dec 25, 2024 · 1 comment · Fixed by #206
Assignees

Comments

@tyler-dane
Copy link
Contributor

Where did this happen?

Local code with an up-to-date main branch

Expected Behavior

An event shouldn't be allowed to be edited or deleted while it is being rendered optimistically

Current Behavior

During the timespan where the optimistically generated event is created and the HTTP request returns a response from the server:

The event cannot be drag and dropped
The event cannot be deleted (would delete a local version but the API would re-generate a new one after the HTTP request returns a response)

Steps to Reproduce

  1. Create Event
  2. Change event
  3. While event change is being processed on backend, change the event again

Possible Solution

Prevent the changes while an event is optimistically rendered

Context

#197 introduced optimistic rendering.

@tyler-dane tyler-dane added the bug label Dec 25, 2024
@tyler-dane tyler-dane moved this to Backlog in 🏗 Compass Roadmap Dec 25, 2024
@tyler-dane tyler-dane moved this from Backlog to Ready in 🏗 Compass Roadmap Dec 25, 2024
@that-one-arab
Copy link
Contributor

Assign me this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants