🐛 Fix: Disable newly created event from being editing during optimistic render cycle #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… render cycle Prevents the event from being modified when we initially insert the event as an optimistic event
the previous solution worked fine, but it came with the overhead of another color map in theme.util. We're going to get away from these as we support more priorities, so this method lets us scale with more ease
|
Thank you for sharing your thought process, @that-one-arab. I like how your solution is simple yet also offers an intuitive UX. I especially like how the styles only change onHover, allowing users to not have to think about what's happening behind the scenes. I followed up with one cleanup commit. The original implementation worked fine, but it came with the overhead of another color map in theme.util. We're going to get away from these as we support more priorities, so this method lets us scale with more ease |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While you already proposed a solution for this issue here, preventing the user from initially DnD or editing the event did not seem very UI/UX friendly to me.
I thought about and researched other solutions, the best solution to handle this issue is to implement Transactional State Management to handle this type of transient data, but this implementation itself is split into many strategies.
Each strategy has its own pros and cons, but they all share 1 same con and that is they are difficult to implement and adds lots of overhead.
The 2nd best approach was to simply display a loading indication when the event is initially being created, removing the optimistic approach entirely.
But this would:
So the best thing we can do here is to implement your proposed solution which is disabling edits during its optimistic status.
I tried my best to make it UI/UX friendly by displaying a different cursor and a distinct background color to indicate we are doing some loading to the user.
I included all this extra context as logs for future reference and your own consideration.
Demo
Peek.2024-12-28.16-31.webm