🐛 Fix: Date picker not closing after selecting date #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilo9
changed the title
|
Looks good, @murilo9! Glad we could remove some of that code. I think you're right about that code being there as a result of an older implementation. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #131.
The problem was caused by DatePicker's wrapper div onFocus, which was calling the openEndDatePicker and openStartDatePicker functions. Those functions were setting DatePicker's state to keep it open. As the open/close logic of DatePicker is managed by the DatePicker component itself, there is no need to have those functions anymore (I guess they were part of some older implementation logic).
All tests have passed.