Skip to content
executor

fix garage #215

Sign in to view logs

fix garage

fix garage #215

GitHub Actions / clippy failed Dec 18, 2024 in 0s

clippy

2 errors, 4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 2
Warning 4
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check failure on line 141 in utils/poll-runner/src/encrypt.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item without indentation 

error: doc list item without indentation
   --> utils/poll-runner/src/encrypt.rs:141:5
    |
141 | /// The password is decrypted using the private key and used to decrypt the data.
    |     ^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
    |
141 | ///   The password is decrypted using the private key and used to decrypt the data.
    |     ++

Check failure on line 85 in utils/poll-runner/src/encrypt.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item without indentation 

error: doc list item without indentation
  --> utils/poll-runner/src/encrypt.rs:85:5
   |
85 | /// The ticket is then encoded using the URL safe base64 encoding.
   |     ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
   = note: `-D clippy::doc-lazy-continuation` implied by `-D clippy::all`
   = help: to override `-D clippy::all` add `#[allow(clippy::doc_lazy_continuation)]`
help: indent this line
   |
85 | ///   The ticket is then encoded using the URL safe base64 encoding.
   |     ++

Check warning on line 31 in lib/bootstrap/src/nc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a shared reference to mutable static is discouraged 

warning: creating a shared reference to mutable static is discouraged
  --> lib/bootstrap/src/nc.rs:31:13
   |
31 |             SINGLETON.assume_init_ref().clone()
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static
   |
   = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
   = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives

Check warning on line 28 in lib/bootstrap/src/nc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged 

warning: creating a mutable reference to mutable static is discouraged
  --> lib/bootstrap/src/nc.rs:21:17
   |
21 | /                 SINGLETON.write(Arc::new(
22 | |                     nats::asynk::connect(
23 | |                         std::env::var("NATS_URL")
24 | |                             .expect("Expected the NATS_URL in the environment"),
...  |
27 | |                     .expect("Failed to connect to NATS"),
28 | |                 ));
   | |__________________^ mutable reference to mutable static
   |
   = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
   = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives

Check warning on line 33 in lib/bootstrap/src/db.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a shared reference to mutable static is discouraged 

warning: creating a shared reference to mutable static is discouraged
  --> lib/bootstrap/src/db.rs:33:13
   |
33 |             SINGLETON.assume_init_ref().clone()
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static
   |
   = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
   = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives

Check warning on line 30 in lib/bootstrap/src/db.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged 

warning: creating a mutable reference to mutable static is discouraged
  --> lib/bootstrap/src/db.rs:20:17
   |
20 | /                 SINGLETON.write(Arc::new(
21 | |                     PgPoolOptions::new()
22 | |                         .min_connections(1)
23 | |                         .max_connections(5)
...  |
29 | |                         .expect("should be able to create the database pool"),
30 | |                 ));
   | |__________________^ mutable reference to mutable static
   |
   = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
   = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
   = note: `#[warn(static_mut_refs)]` on by default
View more details on GitHub Actions