Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / Stutter as individual settings menu for each clip / kit row / kit global / song global #3226

Merged

Conversation

soymonitus
Copy link
Contributor

@soymonitus soymonitus commented Jan 6, 2025

Also implemented PingPong in addition to Reverse and Quantize

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Results

106 tests  ±0   106 ✅ ±0   1s ⏱️ -1s
 16 suites ±0     0 💤 ±0 
 16 files   ±0     0 ❌ ±0 

Results for commit 76079b1. ± Comparison against base commit f8a9c57.

♻️ This comment has been updated with latest results.

@soymonitus
Copy link
Contributor Author

This is ready for review

@soymonitus soymonitus changed the title Implement Stutter as individual settings menu for each modControllableAudio clip Feature / Stutter as individual settings menu for each clip / kit / song Jan 7, 2025
@soymonitus soymonitus changed the title Feature / Stutter as individual settings menu for each clip / kit / song Feature / Stutter as individual settings menu for each clip / kit row / kit global / song global Jan 7, 2025
@m-m-adams
Copy link
Collaborator

code looks good to me but I haven't had a chance to try it at all

# Conflicts:
#	src/deluge/model/fx/stutterer.cpp
#	src/deluge/model/fx/stutterer.h
#	src/deluge/model/mod_controllable/mod_controllable_audio.cpp
@stellar-aria stellar-aria added this pull request to the merge queue Jan 19, 2025
Merged via the queue into SynthstromAudible:community with commit 9a57771 Jan 19, 2025
6 checks passed
@soymonitus soymonitus deleted the monitus/stutter_setting branch January 19, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants