Refactor/make voice sane again #3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-m-adams
force-pushed
the
refactor/make_voice_sane_again
branch
2 times, most recently
from
ddc84ef to
152d647
Compare
m-m-adams
force-pushed
the
refactor/make_voice_sane_again
branch
from
152d647 to
a114aca
Compare
sapphire-arches
approved these changes
Jan 11, 2025
Merged
via the queue into
SynthstromAudible:community
with commit Jan 12, 2025
45c4126
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, just move the oscillator rendering out to the dsp folder and refactor to remove gotos
Also fix a bug where wavetables would needlessly run the amplitude vector code when it's not being applied, which nets to a couple of extra wavetable voices