Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Midi Follow CC assignments to use lookup tables and add rest of automateable parameters #3257

Merged
merged 18 commits into from
Jan 18, 2025
Merged

Refactor Midi Follow CC assignments to use lookup tables and add rest of automateable parameters #3257

merged 18 commits into from
Jan 18, 2025

Conversation

soymonitus
Copy link
Contributor

@soymonitus soymonitus commented Jan 10, 2025 •
edited
Loading

  • Refactor Midi Follow to use lookup tables (quicker to resolve the values and not tied to grid)
  • Add the rest of parameters to be controlled by midi follow
    • New arpeggiator parameters
    • Stutter rate
    • Compressor threshold
    • New envelopes

TO DO:

  • Upload the new Loopy Pro template
  • Fix bug with loading midi follow xml
IMG_6171.mov

shortcuts

reserved

list

@soymonitus soymonitus marked this pull request as draft January 10, 2025 19:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

Test Results

106 tests  ±0   106 ✅ ±0   0s ⏱️ -1s
 16 suites ±0     0 💤 ±0 
 16 files   ±0     0 ❌ ±0 

Results for commit 0e7af7d. ± Comparison against base commit fa3f446.

♻️ This comment has been updated with latest results.

@soymonitus soymonitus marked this pull request as ready for review January 12, 2025 19:30
@soymonitus soymonitus marked this pull request as draft January 12, 2025 19:31
@soymonitus soymonitus marked this pull request as ready for review January 12, 2025 23:06
@soymonitus
Copy link
Contributor Author

@seangoodvibes this is ready for review

@soymonitus soymonitus changed the title [Draft] Refactor Midi Follow CC assignments to use lookup tables and add rest of automateable parameters Refactor Midi Follow CC assignments to use lookup tables and add rest of automateable parameters Jan 12, 2025
@soymonitus
Copy link
Contributor Author

@m-m-adams did you see anything else to change or is it good to go? :)

@stellar-aria stellar-aria added this pull request to the merge queue Jan 18, 2025
Merged via the queue into SynthstromAudible:community with commit 0d79ad6 Jan 18, 2025
6 checks passed
@soymonitus soymonitus deleted the monitus/arp_params_in_midi_follow branch January 18, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-m-adams m-m-adams m-m-adams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soymonitus @m-m-adams @stellar-aria