Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust default global effectable volume to 25/50 instead of 38/50 #3272

Conversation

seangoodvibes
Copy link
Collaborator

@seangoodvibes seangoodvibes commented Jan 12, 2025

Changes default song volume to 25/50 instead of 38/50 as we're always telling people to reduce their song volume to avoid clipping.

This was originally introduced in PR #1230 but was reversed due to the change to the preset loading volume (that's not in this PR)

Fix #3271

Originally introduced this in PR SynthstromAudible#1230

Bringing it back as we're always telling people to reduce their song volume to avoid clipping

But was reversed due to the change to the preset loading volume (that's not in this PR)
Copy link
Contributor

Test Results

106 tests  ±0   106 ✅ ±0   0s ⏱️ -1s
 16 suites ±0     0 💤 ±0 
 16 files   ±0     0 ❌ ±0 

Results for commit b9b6890. ± Comparison against base commit 847ffbd.

@seangoodvibes seangoodvibes added this pull request to the merge queue Jan 12, 2025
Merged via the queue into SynthstromAudible:community with commit c52f81b Jan 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default song volume is too high and leads to clipping
2 participants