Added 2 more envelopes #3279
Merged
Added 2 more envelopes #3279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would appreciate if this was rebased to preserve my authorship of the envelope commit. (Amending with Not a huge deal, but, eh. |
Co-authored-by: Raúl Muñoz <[email protected]>
sapphire-arches
force-pushed
the
monitus/more_envelopes
branch
from
fb1056b to
e74d4e1
Compare
|
I think this PR needs to be merged without squashing commits, so authorship of "Added 2 envelopes" by Nikodemus is preserved? |
seangoodvibes
approved these changes
Jan 13, 2025
Merged
via the queue into
SynthstromAudible:community
with commit Jan 13, 2025
9b843d9
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full credit to @nikodemus
This PR adds two more envelopes, which can be accessed from the sound editor menu.
In a future PR (Layered Menus), they could be made accessible from double clicking the ADSR shortcuts on the grid, but this is not in scope in this PR