If there's no sustain and no release just stop the voice #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellar-aria
requested changes
Jan 15, 2025
stellar-aria
approved these changes
Jan 15, 2025
Co-authored-by: Katherine Whitlock <[email protected]>
m-m-adams
force-pushed
the
bugfix/dont_render_silent_voices
branch
from
14583b8 to
7b593c3
Compare
m-m-adams
commented
Jan 16, 2025
stellar-aria
approved these changes
Jan 18, 2025
Merged
via the queue into
SynthstromAudible:community
with commit Jan 18, 2025
3900b22
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With drums (or anything without a release stage) they can just keep getting silently rendered for a long time.... so just re enable the check to not do that?