Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Start Marker Editing in Audio Clip View #3284

Closed

Conversation

m0nkmaster
Copy link

@m0nkmaster m0nkmaster commented Jan 15, 2025

Adds the ability to edit the starting point of audio clips directly from the clip view, similar to how end points are currently edited. This makes manipulating audio clip trimming more intuitive and efficient and removes the need for the "reverse the clip then crop the end, revert reverse" workaround. See: https://www.youtube.com/watch?v=JoLCEb-pv-A&t=1304s. Here's another workaround using Arranger view: https://www.youtube.com/watch?v=iWhVUsx40Mg&t=76s .

Changes

  • Added startMarkerVisible state to track when start marker is being edited
  • Implemented start marker showing in blue (end marker stays red)
  • Modified waveform rendering to respect both start and end markers
  • Added proper cleanup of clip playback state during marker edits

Usage

To edit the start point:

  1. Press any pad in the first column where your audio clip starts
  2. The start marker will appear in blue
  3. Press another pad to move the start point
  4. Press the same pad again to hide the marker

To edit the end point (unchanged):

  1. Press any pad in the last column where your audio clip ends
  2. The end marker will appear in red
  3. Press another pad to move the end point
  4. Press the same pad again to hide the marker

…endering

- Add start marker functionality with blue color indicator
- Implement waveform rendering between start and end markers
- Fix clip playback state during marker edits
- Clean up code structure and improve variable naming
@m0nkmaster m0nkmaster changed the title Add Start Marker Editing for Audio Clips Add Start Marker Editing in Audio Clip view Jan 15, 2025
@m0nkmaster m0nkmaster changed the title Add Start Marker Editing in Audio Clip view Add Start Marker Editing in Audio Clip View Jan 15, 2025
m0nkmaster and others added 3 commits January 15, 2025 21:18
- Fix duplicate needRendering label
- Add proper bounds checking for start positions
- Improve reversed clip handling
- Fix action/undo system for start position changes
@m0nkmaster m0nkmaster closed this Jan 16, 2025
@m0nkmaster m0nkmaster deleted the audio-beginning-crop branch January 16, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants