Maybe fix ghost notes issue? #3288
Open
+47
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,7 +87,7 @@ class Instrument : public Output { | |||
|
|
|||
| virtual bool isAnyAuditioningHappening() = 0; | |||
|
|
|||
| uint8_t defaultVelocity; | |||
| uint8_t defaultVelocity = FlashStorage::defaultVelocity; | |||
There was a problem hiding this comment.
Just want to make sure, the flash storage is already read before this default variable is initialized?
There was a problem hiding this comment.
Good question. The timing hasn't changed by moving it here (initialization still happens at instantiation), so I presume it is fully set up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It definitely fixes an oversight where .insertElementIfNonePresent() was replaced with emplace() instead of operator[]/at(), as it does assignment in addition to insertion