Check resources prior to running tasks #3297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/OSLikeStuff/task_scheduler/task_scheduler.cpp
m-m-adams
force-pushed
the
bugfix/check_resources_before_starting_tasks
branch
from
3ec0600 to
87cb47e
Compare
stellar-aria
requested changes
Jan 18, 2025
m-m-adams
force-pushed
the
bugfix/check_resources_before_starting_tasks
branch
from
c02e0e4 to
5a82c83
Compare
stellar-aria
approved these changes
Jan 19, 2025
|
@m-m-adams looks like the tests need to be updated now |
stellar-aria
approved these changes
Jan 19, 2025
Merged
via the queue into
SynthstromAudible:community
with commit Jan 19, 2025
d37eb1f
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that all of a tasks resources are available before trying to start it
This avoids deadlock from two tasks waiting on each other (it's essentially priority ceiling if all tasks had the same priority) as well as preventing multiple access to single resources