Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Default In-Key Keyboard Layout optimizations. #3303

Open
wants to merge 2 commits into
base: community
Choose a base branch
from

Conversation

todd-gochenour
Copy link
Contributor

@todd-gochenour todd-gochenour commented Jan 21, 2025

My favorite keyboard is the In-Key layout for its muted monotonic color composition. I find it easier to visualize and comprehend relative notes in a scale without the wash of color. I have made this keyboard layout my default.

Problem with this default is that there is no chromatic equivalent. Pressing the SCALE button to change between diatonic and chromatic layouts does nothing. What I want displayed is the Isomorphic keyboard lit with the same muted color composition. This layout makes obvious which notes are diatonic and which notes lie outside of scale. Diatonic notes are lit and notes outside the scale are black. When changing from a major to a minor scale, the shifting diatonic notes are visually identifiable.

This design language should also be used by the synth kit's audition pads. Currently audition pads show a colored root note and a stack of either 6 or 10 black notes depending on SCALE before the next root. Lighting the diatonic notes and having the Perfect 5th degree slightly brighter helps visual comprehension by dividing the lower three diatonic notes from the upper two. Note rows become identifiable at a glance. No more pressing buttons to see popups.

The KEYBOARD and SCALE buttons should operate independent of each other. Pressing the KEYBOARD button shouldn't affect the state of SCALE. There are 4 states that the layout could be in:

  • If SCALE is on and KEYBOARD is on, then the In-Key keyboard layout is used.
  • If SCALE is off and KEYBOARD is on, then the Isomorphic keyboard layout is used.
  • If SCALE is on and KEYBOARD is off, then the audition pads show lit diatonic notes same as the In-Key keyboard.
  • If SCALE is off and KEYBOARD is off, then the audition pads show lit diatonic notes and black outside notes, same as the Isomorphic keyboard.

These optimizations are implemented strictly when the In-Key keyboard layout is set as the System Default. The other layout options available, Isomorphic and Piano, continue to function unchanged. The method for choosing keyboard layouts using KEYBOARD--SELECT-ENC continues to function unchanged.

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Test Results

107 tests  ±0   107 ✅ ±0   0s ⏱️ -1s
 16 suites ±0     0 💤 ±0 
 16 files   ±0     0 ❌ ±0 

Results for commit 019aeea. ± Comparison against base commit c3c3918.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant