-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Battery Status Display to Session View 🔋🪫 #3310
Draft
m0nkmaster
wants to merge
56
commits into
SynthstromAudible:community
Choose a base branch
from
m0nkmaster:power-level
base: community
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+442
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes only when necessary.
…tialBatteryChange method for updates, and improved battery display rendering in session view.
…clarity, improved comments, and ensured consistent formatting in the battery icon rendering logic.
…tes only when necessary.
…tialBatteryChange method for updates, and improved battery display rendering in session view.
…clarity, improved comments, and ensured consistent formatting in the battery icon rendering logic.
src/deluge/deluge.cpp
Outdated
|
||
// Update battery display if voltage has changed significantly | ||
// TODO: Do we need this, can it be self-contained in session_view? | ||
sessionView.displayPotentialBatteryChange(newBatteryMV); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably don't need it here as I see you already have it in session view :: graphics routine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces battery status OLED monitoring and USB power detection.
Key Changes
Testing
Caveats
Follows this discussion:
#2991