Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprint 2 #102

Merged
merged 47 commits into from
Aug 1, 2024
Merged

Sprint 2 #102

merged 47 commits into from
Aug 1, 2024

Conversation

wwelling
Copy link

@wwelling wwelling commented Jul 31, 2024 •
edited
Loading

Replaces #97

  • #91 Users should be uniquely identified using UIN
  • #82 Duplicate options for Major and ORCID in disable column section
  • #83 Submission Status pane shows wrong last action date
  • #53 Show list of graduation semester in sidebar
  • #51 Display First and Last Name in single column
  • #81 Last Event display without values in List view

kaladay and others added 30 commits July 12, 2024 09:40
@kaladay
Fix Test failure regarding EmailRecipientContactTest file.
e11dc54 
The error:
```
[ERROR] Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0 s <<< FAILURE! - in org.tdl.vireo.model.EmailRecipientContactTest
[ERROR] testGetEmails  Time elapsed: 0 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: Emails array does not have the correct length. ==> expected: <0> but was: <2>
	at org.tdl.vireo.model.EmailRecipientContactTest.testGetEmails(EmailRecipientContactTest.java:50)
```

This PR and commit:
- TexasDigitalLibrary#1923
- TexasDigitalLibrary@7b4a7b8

Did not also update the unit test.

This updates the unit test to now mock `getFieldValuesByPredicateValue()` instead of mocking `getFieldValuesByPredicate()`.
@wwelling
Merge pull request #85 from TAMULib/sprint2-fix_breaking_EmailRecipie…
1f2bfcb 
…ntContactTest

Fix Test failure regarding EmailRecipientContactTest file.
@wwelling
Sort action log by date to obtain most recent action
ce7785a
@wwelling
Fix new field value controller
2022e5f
@wwelling
Update submission list filter by graduation semester
86178a1
@wwelling
Make title unique on submission list column
02f2969 
Submission list column title and predicate are derived without referential integrity from organization workflow field profile gloss and field profile field predicate value.
@wwelling
Add Student Name submission list column with combined predicate
3b6ca23
@wwelling
Update the submission query to afford sorting on combined predicate
0bb5566
@wwelling
Update submission list to render column for combined predicates
5c769a6
@wwelling
Sort the graduation semesters
5016d6f
@wwelling
Update system data loader test
1324851
@wwelling
Fix organization management controller tests
ca2581d
@wwelling @qtamu
Make user netid unique
3961eee 
Co-Authored-By: Q'Sean <[email protected]>
@wwelling @qtamu
Add find by netid user repository method
20145c8 
Co-Authored-By: Q'Sean <[email protected]>
@wwelling @qtamu
Optionally use netid as user unique identifier
f586e46 
Co-Authored-By: Q'Sean <[email protected]>
@wwelling
Update credentials service to respect shibboleth configurations
1375dbf
@wwelling
Update shibboleth mapping configurations
f654a01
@wwelling
Update system organization field profiles with mapped shib attribute
a92542d
@wwelling
Remove system out println
fab5b9b
@wwelling
Fix field profile repo tests
caa1ccd
@wwelling
Merge pull request #95 from TAMULib/sprint2-91-user-credentials-shibb…
46e00bb 
…oleth-mapping

Update shibboleth mapping configurations
@wwelling
Add exception handler for file not found
2491915
@wwelling
Ignore hibernate contact info properties
c2d377a
@wwelling
Afford sorting and filtering by last action of submission
db0d5b2
@wwelling
Make graduation semester sort method exception safe
0f8fc87
@wwelling
Update role when admin email defined in properties
1218ca7
@wwelling
Check submission action logs have at least one entry to avoid null po…
85e5528 
…inter
@wwelling
Do not repeat yourself and use strict equality
7b02834
@wwelling
Remove redundant string builder appends
fd364b6
@wwelling
Map submission list column field values
490cfed
wwelling added 12 commits July 31, 2024 03:30
@wwelling
Restore further filter by graduation semester as date
cebc35b
@wwelling
Add filter by graduation semester as list
f4f6d00
@wwelling
Coalesce named search filter group by first selected filter from subm…
a7620e8 
…ission list column
@wwelling
Merge branch 'sprint2-53-graduation-semester-facet' of github.com:TAM…
3e9122d 
…ULib/Vireo into sprint2-staging-patches
@wwelling
Merge branch 'sprint2-82-duplicate-submission-list-column-options' of…
083ee75 
… github.com:TAMULib/Vireo into sprint2-staging-patches
@wwelling
Merge branch 'sprint2-51-combined-column-sort' of github.com:TAMULib/…
ac37354 
…Vireo into sprint2-staging-patches
@wwelling
Merge branch 'sprint2-fix-ci-build' of github.com:TAMULib/Vireo into …
ba11ea5 
…sprint2-staging-patches
@wwelling
Merge branch 'sprint2-91-user-unique-identifier' of github.com:TAMULi…
84f8fd2 
…b/Vireo into sprint2-staging-patches
@wwelling
Merge branch 'sprint2-91-user-credentials-shibboleth-mapping' of gith…
3cb2784 
…ub.com:TAMULib/Vireo into sprint2-staging-patches
@wwelling
Merge branch 'sprint2-81-last-action-list-view' of github.com:TAMULib…
0becbb6 
…/Vireo into sprint2-staging-patches
@wwelling
Update system data loader test for additional system submission list …
55572e1 
…column
@wwelling
Update submission list controller tests
271cf01
@wwelling wwelling requested a review from a team July 31, 2024 19:56
@wwelling wwelling force-pushed the sprint2-staging-patches branch from d085270 to 8bf2444 Compare July 31, 2024 21:05
@wwelling wwelling merged commit da71370 into main Aug 1, 2024
2 checks passed
@wwelling wwelling deleted the sprint2-staging-patches branch January 9, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaladay kaladay kaladay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwelling @kaladay