Updated display view sorting #455
Merged
+24
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwelling
reviewed
Jan 13, 2025
| @@ -415,7 +415,7 @@ | |||
| - field: subtype | |||
| value: Album | |||
| sort: | |||
| - field: dateTimeIntervalStart | |||
| - field: dateTimeInterval.Start | |||
There was a problem hiding this comment.
The property start should be all lowercase.
Suggested change
| - field: dateTimeInterval.Start | |
| - field: dateTimeInterval.start |
There was a problem hiding this comment.
Update has been made, please verify.
kaladay
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Please correct me if I am wrong as I am not as familiar with this code base.
I see multiple sections for field: creativeWorks where dateTimeIntervalStart is in use.
Shouldn't all of these be updated and not just the "Albums" subsection?
And so on...
And what about the resources defaults yaml file.
Should that also be updated (for creativeWorks fields)?
|
@kaladay yes, all of the creative works subsections |
kaladay
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #454
Updated display view results to sort by date.