Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): standarize DOCTYPE declaration #104

Open
wants to merge 1 commit into
base: v2.0
Choose a base branch
from

Conversation

rnmeow
Copy link

@rnmeow rnmeow commented Dec 22, 2024

As titled.

@rnmeow rnmeow changed the title fix(template): standarize HTML5 declaration fix(template): standarize DOCTYPE declaration Dec 22, 2024
@LifeAdventurer
Copy link
Collaborator

I noticed that this PR updates the <!DOCTYPE> declaration in a single HTML file. If your intention is to make this change across the project for consistency, please ensure that all HTML files are updated, not just one. This helps maintain uniformity throughout the codebase.

If this change was meant for just this file, could you clarify why? Otherwise, I recommend updating all relevant files in the project to reflect this change.

Looking forward to your response!

@rnmeow
Copy link
Author

rnmeow commented Dec 23, 2024

I noticed that this PR updates the <!DOCTYPE> declaration in a single HTML file. If your intention is to make this change across the project for consistency, please ensure that all HTML files are updated, not just one. This helps maintain uniformity throughout the codebase.

If this change was meant for just this file, could you clarify why? Otherwise, I recommend updating all relevant files in the project to reflect this change.

Looking forward to your response!

With a quick search across the project, it turns out that only one file was related to the typo.

As you might notice, all pages are being generated from the index.html template. That is clearly a clever engineering act which avoids duplications.

@LifeAdventurer
Copy link
Collaborator

I’ve reviewed the project again and realized my earlier assumption about other files containing the <!DOCTYPE> declaration was incorrect. It seems I mistakenly thought there might be more instances, but it’s now clear that all pages are generated from the single index.html template.

Thank you for clarifying this! Your change makes sense in this context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants