Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ricardo simoes patch 2 #1224

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

Ricardo-Simoes
Copy link
Contributor

Portuguese Portugal (pt_PT) 100% translated

PT 100% translated
Portuguese Portugal (pt_PT) 100% translated
@Ricardo-Simoes
Copy link
Contributor Author

Portuguese Portugal (pt_PT) 100% translated

@Taiko2k
Copy link
Owner

Taiko2k commented Nov 16, 2024

There are some small merge conflicts currently blocking this from merging, could you fix them?

@Ricardo-Simoes
Copy link
Contributor Author

There are some small merge conflicts currently blocking this from merging, could you fix them?

Sorry, I don't understand the conflicts... is (pt) locale/pt/LC_MESSAGES/tauon.po Portuguese Brazilian? Perhaps, because pt-PT is definitely Portuguese Europen (Portugal), and I'm not Brazilian, I'm Portuguese. Can you please advise?

@Taiko2k
Copy link
Owner

Taiko2k commented Nov 17, 2024

I assume pt is the same as pt_PT, so pt is redundant if both pt_PT and pt_BR is present, not sure of the ramifications of deleting pt though.

In any case I don't think it matters, you just gotta hack at this to make it mergable.

@Ricardo-Simoes
Copy link
Contributor Author

Please check now if everything is corrected.
Many thanks, and best regards.

@C0rn3j
Copy link
Collaborator

C0rn3j commented Nov 22, 2024

@Ricardo-Simoes Would you be down to fix the remaining issues with the files in a new PR?

Tauon/locale/pt/LC_MESSAGES/tauon.po:3095: duplicate message definition...
Tauon/locale/pt/LC_MESSAGES/tauon.po:1520: ...this is the location of the first definition
Tauon/locale/pt/LC_MESSAGES/tauon.po:3098: duplicate message definition...
Tauon/locale/pt/LC_MESSAGES/tauon.po:1524: ...this is the location of the first definition
Tauon/locale/pt/LC_MESSAGES/tauon.po:3101: duplicate message definition...
Tauon/locale/pt/LC_MESSAGES/tauon.po:1532: ...this is the location of the first definition
Tauon/locale/pt/LC_MESSAGES/tauon.po:3226: duplicate message definition...
Tauon/locale/pt/LC_MESSAGES/tauon.po:2232: ...this is the location of the first definition
Tauon/locale/pt_PT/LC_MESSAGES/tauon.po:3265: duplicate message definition...
Tauon/locale/pt_PT/LC_MESSAGES/tauon.po:1383: ...this is the location of the first definition

I've added CI runs for translations that will land when #1305 gets merged, which should make this obvious in the future.

EDIT: Fixed in the above linked PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants