Fix getting length from libopenmpt as infinity, which could crash with Protracker modules #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rn3j
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle passing infinity to
get_display_time()by logging an error and parsing ??:?? back, this fixes an instant crash should we supply such a file that manages to get mangled by tag_scan() as such.Also handle the root cause that was causing this - we were not handling a possible infinity libopenmpt can throw if it fails to parse the file length.
Upstream report - https://bugs.openmpt.org/view.php?id=1857
Also fix typing for the function and add some small touchups.
Repro broken .mod file was posted in https://discord.com/channels/687418493209018622/915799586168270878/1328664124254715934