feat: add a "disableValueCache" option #5139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using tanstack table with proxy objects as row data, copying cell values to the cache is unwanted behavior as they are no longer connected to the row proxy object. In these scenarios i'd like to turn off the value cache. ref TanStack#4876
|
@OlaAlsaker Curious on your opinion on this PR. I was originally saving this type of change for v9 |
|
I don't this change is necessary anymore after we introduced support for reactivity in |
|
Sure I was kinda reshifted to another project, but I'll check with my collegues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using tanstack table with proxy objects as row data, copying cell values to the cache is unwanted behavior as they are no longer connected to the row proxy object. In these scenarios i'd like to turn off the value cache.
ref #4876
To illustrate the problem further You can read this comment and see the attached sandbox examples: #4876 (comment)