Merge pull request #2118 from glensc/dl-check-error

Fix: Catch missing subtitle files on download
Taxel · Dec 26, 2024 · c0b477e · c0b477e · alzee28 · Dec 29, 2024
2 parents 1f11c87 + 1b9cbd3
commit c0b477e
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/plextraktsync/commands/download.py b/plextraktsync/commands/download.py
@@ -4,7 +4,9 @@
 from pathlib import Path, PureWindowsPath
 from typing import TYPE_CHECKING
 
-from plextraktsync.factory import factory
+from plexapi.exceptions import NotFound
+
+from plextraktsync.factory import factory, logger
 from plextraktsync.util.expand_id import expand_plexid
 
 if TYPE_CHECKING:
@@ -48,10 +50,14 @@ def download_subtitles(plex: PlexApi, pm: PlexLibraryItem, savepath: Path):
             continue
 
         if not sub.key:
-            print(f"  ERROR: Subtitle {index}: has no key: Not downloadable")
+            logger.error(f"Subtitle {index}: has no key: Not downloadable")
             continue
 
-        plex.download(sub, savepath=savepath, filename=filename, showstatus=True)
+        try:
+            plex.download(sub, savepath=savepath, filename=filename, showstatus=True)
+        except NotFound:
+            logger.error(f"Subtitle {index}: File doesn't exist: Not downloadable")
+            continue
         print(f"Downloaded: {filename}")