Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : modal #134

Merged
merged 5 commits into from
Apr 10, 2024
Merged

refactor : modal #134

merged 5 commits into from
Apr 10, 2024

Conversation

Ubinquitous
Copy link
Member

What

모달을 리팩토링했습니다.

How

  • 사용하지 않는 Alert 모달을 삭제했습니다.
  • useModal 함수를 사용하여 호출해야했던 기존의 모달 형식에서 useModal에 openConfirm 메서드를 추가정의하여 간편화시켰습니다.
  • Confirm의 확장성을 고려하여 props를 재설계하고, CreateCoinAccount 컴포넌트를 삭제하고 확장된 Confirm으로 로직을 처리했습니다.

@Ubinquitous Ubinquitous self-assigned this Apr 9, 2024
@Ubinquitous Ubinquitous merged commit 2a353ca into main Apr 10, 2024
2 checks passed
@Ubinquitous Ubinquitous deleted the refactor/modal branch November 15, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5ewon 5ewon Awaiting requested review from 5ewon 5ewon is a code owner

@jyh071116 jyh071116 Awaiting requested review from jyh071116 jyh071116 is a code owner

Assignees

@Ubinquitous Ubinquitous

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ubinquitous