Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flat_classification_report. #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chriswales95
Copy link

@chriswales95 chriswales95 commented Oct 27, 2021

  • Change positional argument to keyword argument in flat_classification_report.

@mdcclv
Copy link

mdcclv commented Nov 18, 2021

This is good, thank you for doing it. I hope it gets merged.

@glorytheksy
Copy link

Thanks!

@costika1234
Copy link

Is it possible to merge this PR and release a new version? @kmike ?

@kmike
Copy link
Contributor

kmike commented May 11, 2022

Is it possible to merge this PR and release a new version? @kmike ?

Apparently it's not @costika1234, unfortunately I've lost commit access to this repo :( I still have pypi access though. It's a matter of putting some work to copy the repo somewhere.

@costika1234
Copy link

I see, @kmike. Do you happen to know the people who have access to this repo? If not, then I would advise moving this repo somewhere else so that you can deploy a new version containing this fix (and subsequent ones, too).

MeMartijn added a commit to MeMartijn/updated-sklearn-crfsuite that referenced this pull request Jun 27, 2022
@MeMartijn
Copy link

I needed this change and the change from #69 for my code to work, so, seeing that the package is not updated anymore, I created a new fork with your fix and the fix from #69.

If anyone needs both, you can start using an updated version of this package by running this:
pip install git+https://github.com/MeMartijn/updated-sklearn-crfsuite.git#egg=sklearn_crfsuite. Any updates are welcome, I'll accept all pull requests for bug fixes.

@patrickquick
Copy link

@MeMartijn Thanks for addressing this. However, I'm still getting the same error AttributeError: 'CRF' object has no attribute 'keep_tempfiles' after installing the updated version. Can I provide anything to try and tackle what the problem may be? Forgive me for being a little green!

@MeMartijn
Copy link

@patrickquick I'm sorry to hear it doesn't work for you still! I needed this package for a single project and never touched it again, but you can still contribute to my fork that had the initial fix. That way, you would help people that run into your issue too. Here's a link: https://github.com/MeMartijn/updated-sklearn-crfsuite

@dhdaines
Copy link

@MeMartijn Thanks for addressing this. However, I'm still getting the same error AttributeError: 'CRF' object has no attribute 'keep_tempfiles' after installing the updated version. Can I provide anything to try and tackle what the problem may be? Forgive me for being a little green!

If you're running it in a Jupyter notebook you may need to restart not only the kernel but the whole notebook server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants