Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix docker image tags and ghcr.io auth credentials #604

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

PCatinean
Copy link
Contributor

@PCatinean PCatinean commented Mar 20, 2024

Hi @pedrobaeza small fix incoming:

  1. The tags which are pushed should now be as before - {ODOO_VERSION}, {ODOO_VERSION}-onbuild and latest, latest-onbuild (where applicable)
  2. The push to ghcr.io failed with the default credentials, I have switched them to the old ones hoping they will pass this time. If this also fails maybe you need to look into the permissions of the default github.repository_owner / secrets.GITHUB_TOKEN since authentication was sucessful.

Also after this works you would need to delete the extra {ODOO_VERSION}onbuild (with the missing -)

Fingers crossed 🤞

@PCatinean
Copy link
Contributor Author

@pedrobaeza tests have passed, feel free to merge when you have some time

@pedrobaeza pedrobaeza merged commit 62bd75c into Tecnativa:master Mar 20, 2024
11 checks passed
@PCatinean
Copy link
Contributor Author

@pedrobaeza it seems to have worked, all jobs passed and the images now have both architectures available for download.

Last touch would be to delete the stale {ODOO-VERSION}onbuild images like these ones

Screenshot from 2024-03-20 19-07-59

@pedrobaeza
Copy link
Member

I'm not sure how the images are bridged to Docker Hub, as the workflow are supposed to be pushed to ghcr.io, and there, I don't see the other images: https://github.com/tecnativa/doodba/pkgs/container/doodba/versions?page=1

Do you know how this works?

@PCatinean
Copy link
Contributor Author

PCatinean commented Mar 20, 2024

In the initial PR merged I had two bugs:

  1. Added {ODOO_VERSION}onbuild instead of just {ODOO_VERSION}
  2. Credentials used for ghcr.io were different and the user did not have permission to push

For this reason the {ODOO_VERSION}onbuild made it to the docker hub but not ghcr.io. This should not happen any more after the fix and I see the latest push worked well for https://github.com/tecnativa/doodba/pkgs/container/doodba

@PCatinean PCatinean deleted the arm-builds branch March 23, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants