-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Print version (hash) tag whenever app starts #57
Conversation
3beb101
to
5ef742e
Compare
Don't mind the pushes; |
6a94ccf
to
9a9d91f
Compare
@carsten989 i've added you to the reviewer list to only address the issue i'm having with CI integration: it seems like i cannot simply pass for docker action, as this action is included furthermore the action hierarchy; Please note, that this PR currently doesn't work OK with CI, so it's not to be merged yet; NOTE: sample of warning that pops-up Warning: Unexpected input(s) 'build-args', valid inputs are ['image_name', 'registry', 'registry_user', 'registry_password', 'checkout_fetch_depth'] |
So it looks like setting CGW_WSS_THREAD_NUM is no longer supported? |
The confusion basically comes from the following:
The script we used to run deployment manually through the make run actually pointed to enviroment variable:
So i changed it to export right env:
(Because application expects exact name); The pod config should be the same, i've just check it's the <DEFAULT_WSS_THREAD_NUM=8> env var that gets exported; Or are you using the helper script as well, sorry? Did i brake your deployment? |
So, the problem is the changes in this pr still do not work and i think the doc you're referencing is purely for TS, righ? |
@carsten989 maybe we can jump into slack to discuss / find a potential fix or way-to-go for this issue (the docker build-args one)? |
NOTE: CI changes will be made in other PRs. This one only covers the buildsystem / application part; Signed-off-by: Oleksandr Mazur <[email protected]>
Signed-off-by: Oleksandr Mazur <[email protected]>
Originally <as> is lowercased in present Dockerfile, which might omit warnings upon build. Fix this by uppercasing the <AS> instructions. Signed-off-by: Oleksandr Mazur <[email protected]>
9a9d91f
to
969ef8b
Compare
Sample output:
...