Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): no need to traversal sibling views for next responder #3255

Closed
wants to merge 1 commit into from
Closed

fix(ios): no need to traversal sibling views for next responder #3255

wants to merge 1 commit into from

Conversation

ozonelmy
Copy link
Contributor

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@ozonelmy ozonelmy requested a review from wwwcg May 23, 2023 07:52
@ozonelmy ozonelmy marked this pull request as draft May 23, 2023 07:52
@github-actions github-actions bot added framework: ios size: s Denotes a PR that changes 10-99 lines labels May 23, 2023
@hippy-service
Copy link

hippy-service bot commented May 23, 2023

Hi, @ozonelmy. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@ozonelmy ozonelmy marked this pull request as ready for review May 26, 2023 04:06
wwwcg
wwwcg requested changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@wwwcg wwwcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不能取消对sibling节点的遍历，某些情况下将会导致兄弟节点丢失事件回调

@hippy-service
Copy link

hippy-service bot commented Sep 5, 2023

Hi, @ozonelmy, I noticed that our reviewers requested changes to this pull request.
When you're done, click the Re-request review button in the right sidebar(shown below) to notify the reviewer.
Re-request review button in the right sidebar

@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 4, 2023

Pay attention 🛎️ !!
There has been no activity on this PR for 2 months, so I will label it stalled.
It will be automatically closed in 30 days if no more activity. Feel free to leave a comment if you have any questions.

@hippy-service hippy-service bot added the stale: 60d No interaction in the last 60 days label Nov 4, 2023
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jan 3, 2024

Sorry, closing this PR because it has stalled for over 4 months.
Feel free to reopen if this PR is still relevant, or to ping the collaborator if you have any questions.

@hippy-service hippy-service bot added the stale: closed Closed due to stale label Jan 3, 2024
@hippy-service hippy-service bot closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwwcg wwwcg wwwcg requested changes

Assignees
No one assigned
Labels
framework: ios size: s Denotes a PR that changes 10-99 lines stale: closed Closed due to stale stale: 60d No interaction in the last 60 days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ozonelmy @wwwcg