-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(action-sheet): simplify initialization logic and enhance observer functionality #3438
Open
betavs
wants to merge
1
commit into
develop
Choose a base branch
from
hotfix/action-sheet-visible
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +21 B (+0.01%) Total Size: 239 kB
ℹ️ View Unchanged
|
anlyyao
reviewed
Jan 13, 2025
下面的 case 中,更新 actions 值后,组件也没有响应
|
@anlyyao 个人认为只有数据更新后在 |
betavs
force-pushed
the
hotfix/action-sheet-visible
branch
from
January 14, 2025 12:20
4bf8e47
to
bc97977
Compare
betavs
changed the title
fix(action-sheet): move initialization to observer for better visibility handling
fix(action-sheet): refactor initialization and observer for items update
Jan 14, 2025
anlyyao
approved these changes
Jan 15, 2025
betavs
force-pushed
the
hotfix/action-sheet-visible
branch
from
January 15, 2025 12:39
bc97977
to
b878d4e
Compare
betavs
changed the title
fix(action-sheet): refactor initialization and observer for items update
refactor(action-sheet): simplify initialization logic and enhance observer functionality
Jan 15, 2025
…erver functionality
betavs
force-pushed
the
hotfix/action-sheet-visible
branch
from
January 15, 2025 12:58
b878d4e
to
d99d08d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
fix #3411
💡 需求背景和解决方案
📝 更新日志
fix(ActionSheet): 数据更新后未更新视图的问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单