make: gui_ prerendering #2610
make: gui_ prerendering #2610
Conversation
flow/scripts/open.tcl
Outdated
| gui::select_clockviewer_clock $clock_name | ||
| save_image -resolution $resolution $::env(REPORTS_DIR)/cts_${clock_name}_layout.webp | ||
| } | ||
| } |
There was a problem hiding this comment.
|
@gadfort "How do I unselect the clock tree and return the GUI to the default view?" |
|
@maliberty Should grt::have_routes return false silently if the instances are not placed? |
|
@maliberty Tried on a larger design, works nicely. Nits need to be fixed, broken out as issues. |
How about The-OpenROAD-Project/OpenROAD#6307 ? |
oharboe
force-pushed
the
make-gui-less-click-and-wait
branch
from
d918d86 to
0e63d2b
Compare
Signed-off-by: Øyvind Harboe <[email protected]>
less click and wait when the GUI opens for large designs clock tree prerendering is still missing, because there is no way yet to disable the clock tree rendering from .tcl after the clock tree has been rendered. Some progress added so that the user can tell what it is that is taking time. Also added a final gui::unminimize log item so the user knows when the GUI should have unminimized(which it doesn't on Ubuntu 24.04 with Wayland yet, known issue filed). make gui_route [deleted] estimate_parasitics -global_routing Populating timing paths...OK Prerendering Placement heatmap... Prerendering Routing heatmap... Prerendering RUDY heatmap... Prerendering Power heatmap... gui::select_chart "Endpoint Slack" gui::update_timing_report gui::unminimize The-OpenROAD-Project/OpenROAD#6074 Signed-off-by: Øyvind Harboe <[email protected]>
oharboe
force-pushed
the
make-gui-less-click-and-wait
branch
from
0e63d2b to
64d013d
Compare
|
@maliberty Ready for review. Preprendering clock tree is still missing, but that's a simple change once this is through and that missing clock tree feature is available in OpenROAD. |
flow/scripts/open.tcl
Outdated
| # FIXME reenable when there is a way to disable the rendered clock tree | ||
| # | ||
| # foreach clock [get_clocks *] { | ||
| # if { [llength [get_property $clock sources]] > 0 } { | ||
| # set clock_name [get_name $clock] | ||
| # save_clocktree_image -clock $clock_name \ | ||
| # -width 100 -height 100 \ | ||
| # $::env(OBJECTS_DIR)/dummy.png | ||
| # break | ||
| # } | ||
| # } |
There was a problem hiding this comment.
open should not write files as a side effect. This should be removed
There was a problem hiding this comment.
Agreed, but how else to precalculate this?
There was a problem hiding this comment.
Does it actually save time? Most of the effort is to get sta warmed up. Drawing the tree should be cheap.
There was a problem hiding this comment.
Yes, last I checked.
However, I can delete the commented code and if this PR is otherwise good to go, we can square away what we already have a solution for and I can then create a new PR with a narrower concern and some numbers.
A way to precalculate this that does not modify GUI state and also does not write files to disk is needed, which isnt available yet, right?
There was a problem hiding this comment.
Yes, if there really is a need. I would be curious to see the time saved.
delete clock tree commented out code for now, revisit later. Signed-off-by: Øyvind Harboe <[email protected]>
|
@maliberty Fixed, should be ready for merge now. This is how far we've come with prerendering for now. Will revisit more later in followup PRs. |
flow/scripts/open.tcl
Outdated
| } | ||
| } | ||
|
|
||
| set have_routes [expr {$placed && [grt::have_routes]}] |
There was a problem hiding this comment.
Do we still need to compute/check $placed? I thought this was fixed.
There was a problem hiding this comment.
Yes: there is no ppl::have_placed method. I can simplify the code a bit here though for the have_routes case.
flow/scripts/open.tcl
Outdated
| } | ||
| puts "Prerendering $heatmap heatmap..." | ||
| gui::set_heatmap $heatmap rebuild 1 | ||
| gui::dump_heatmap $heatmap $::env(REPORTS_DIR)/dummy.png |
There was a problem hiding this comment.
Can we avoid the file side effect?
simplify now that grt::have_routes checks if placement is done first. no need to save dummy.png to prerender. Signed-off-by: Øyvind Harboe <[email protected]>
|
@maliberty Fixed, should be good to go. |
|
good to go? |
|
I think all this warming should have its own control and be off by default. I don't want to spend time on all this if I know what I'm going to be looking at is a subset. |
Would you be happy with a policy to unconditionally compute it at build time? |
|
Meaning: would you agree that it is better to close this PR and then open a more longer term feature request of storing precomputed values unconditionally in the .odb file? |
|
Every option halves the usefulness of a feature. |
|
This is an unconditional penalty on the user who isn't interested in "global warming" 😉 I would be a very long term / large enhancement to store all the sta data in odb. I'm ok if you want to open it but expect the response to be very slow. |
|
@maliberty broke out The-OpenROAD-Project/OpenROAD#6457 and only the timing reports are now updated, but only if GUI_TIMING=1 |
less click and wait when the GUI opens
Clock tree prerendering is still missing, because there is no way yet to disable the clock tree rendering from .tcl after the clock tree has been rendered.
Some progress added so that the user can tell what it is that is taking time. Also added a final gui::unminimize log item so the user knows when the GUI should have unminimized(which it doesn't on Ubuntu 24.04 with Wayland yet, known issue filed).