Feature/issue 1 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to edit what you want from it.
96a324b and e29afc2 are more just aesthetic updates, and for use with actual Composer.
dcf3b60 resolves #1 by adding the license and tidying the Composer JSON info in the README.
4192d5e was an after thought, but looking at it I guess you may want to remove this commit. I was thinking that there's not much point in echoing the file's data if it's already in version control, but then realised that the repo may not always be synced down. I guess maybe another option would be to use
curlorwgetto pull the latest version of the file down. Such as:wget https://raw.githubusercontent.com/TheAdnan/Yiinker/master/src/YiinkerCommand.phpcurl -O https://raw.githubusercontent.com/TheAdnan/Yiinker/master/src/YiinkerCommand.php