Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations, add warning for Contains #377

Merged

Conversation

JuanTecedor
Copy link
Contributor

This PR fixes the deprecation warnings of the comparison operators.

Unsure as if with Contains we should also update the dict field, not just emit a warning.

@JuanTecedor JuanTecedor marked this pull request as ready for review January 6, 2025 22:01
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.98%. Comparing base (570066e) to head (8bec9b7).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   92.94%   92.98%   +0.04%     
==========================================
  Files          27       27              
  Lines         751      756       +5     
==========================================
+ Hits          698      703       +5     
  Misses         53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kamforka
Copy link
Collaborator

Kamforka commented Jan 7, 2025

Looks perfect, only thing missing is the commit signs. Can you try and fix that please?

@JuanTecedor JuanTecedor force-pushed the 376-fix-deprecations-query-filters branch from 64e2019 to 53ff122 Compare January 8, 2025 10:48
@JuanTecedor
Copy link
Contributor Author

Thanks @Kamforka. Signatures should be fixed now

@Kamforka Kamforka self-assigned this Jan 8, 2025
@Kamforka Kamforka self-requested a review January 8, 2025 11:45
@Kamforka Kamforka assigned JuanTecedor and unassigned Kamforka Jan 8, 2025
@Kamforka Kamforka added 2.x changelog:added changelog label for new features. changelog:changed changelog label for changes in existing functionality labels Jan 8, 2025
@Kamforka Kamforka added this to the 2.0.0b8 milestone Jan 8, 2025
tests/test_query_filters.py Show resolved Hide resolved
@Kamforka Kamforka linked an issue Jan 12, 2025 that may be closed by this pull request
@JuanTecedor JuanTecedor force-pushed the 376-fix-deprecations-query-filters branch from 038c9a1 to 8bec9b7 Compare January 12, 2025 18:26
@Kamforka Kamforka merged commit 00a4ceb into TheHive-Project:main Jan 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x changelog:added changelog label for new features. changelog:changed changelog label for changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix deprecations in the query filters
2 participants