-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecations, add warning for Contains #377
Merged
Kamforka
merged 3 commits into
TheHive-Project:main
from
JuanTecedor:376-fix-deprecations-query-filters
Jan 12, 2025
Merged
Fix deprecations, add warning for Contains #377
Kamforka
merged 3 commits into
TheHive-Project:main
from
JuanTecedor:376-fix-deprecations-query-filters
Jan 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
+ Coverage 92.94% 92.98% +0.04%
==========================================
Files 27 27
Lines 751 756 +5
==========================================
+ Hits 698 703 +5
Misses 53 53 ☔ View full report in Codecov by Sentry. |
Looks perfect, only thing missing is the commit signs. Can you try and fix that please? |
JuanTecedor
force-pushed
the
376-fix-deprecations-query-filters
branch
from
January 8, 2025 10:48
64e2019
to
53ff122
Compare
Thanks @Kamforka. Signatures should be fixed now |
Kamforka
added
2.x
changelog:added
changelog label for new features.
changelog:changed
changelog label for changes in existing functionality
labels
Jan 8, 2025
Kamforka
approved these changes
Jan 12, 2025
JuanTecedor
force-pushed
the
376-fix-deprecations-query-filters
branch
from
January 12, 2025 18:26
038c9a1
to
8bec9b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.x
changelog:added
changelog label for new features.
changelog:changed
changelog label for changes in existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the deprecation warnings of the comparison operators.
Unsure as if with
Contains
we should also update the dict field, not just emit a warning.