V3.0 #65
Draft
V3.0 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added framework for movement and sanity checks Loaded prior detections into sfm on boot Lots of logging needed, lots of tests, especially the multiprocessing
Added check for darkness before starting scan
removed cancel_join_thread as it //shouldn't// be needed still need to test if this is an issue and fix
and checking for leds when starting a scan, this needs re-doing but for now it's fine. removed queue clearing which I might have to deal with later.
Hello pathlib, sorry to not invite you from the start mypy, you continue to be a rose/thorn in my side
… weird fixed timeout bumped logging to warning did some sanity checking on the sfm pipeline
Fixed bug where camera would not reset when detector spotted leds before start moved get_overlap_and_percentage to correct location added a few more tests
re-organised the visualiser Lots of stuff to add tests for and also do some testing disabled visualiser if less than 9 points good first draft
Still lots of testing, edge cases and, well, tests to write but this is good for now
Need to break a lot of this down into functions, these if blocks are getting silly
I can guarantee this has broken //something//
# Conflicts: # marimapper/led.py # marimapper/scanner.py # marimapper/sfm_process.py # marimapper/utils.py # pyproject.toml # test/test_led_functions.py
Fixed merge bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.