Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Debug Console component #695

Merged
merged 10 commits into from
Jun 16, 2024
Merged

Add Debug Console component #695

merged 10 commits into from
Jun 16, 2024

Conversation

Mike-MF
Copy link
Member

@Mike-MF Mike-MF commented Jun 9, 2024 •
edited
Loading

When merged this pull request will:

  • Adds some extra buttons for use on the debug console, I can think of a few nice uses for this.
  • Shamelessly stolen from AF.
  • Adds Mass Heal button, global event for fullHealLocal.
  • Adds a make me curator button, checks if already assigned curator to prevent duping, will delete assigned modules on player disconnect.
  • Adds a stop rain button.
  • All buttons log to server RPT who clicked it.

jonpas
jonpas approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots?

@jonpas jonpas added this to the 2.3.0 milestone Jun 13, 2024
@Mike-MF
Copy link
Member Author

Mike-MF commented Jun 13, 2024

https://user-images.githubusercontent.com/4293906/68547546-0f74e500-03e3-11ea-92a2-c8a2daa9bf04.png

@Mike-MF
Copy link
Member Author

Mike-MF commented Jun 15, 2024

Tested alongside @JoramD0 it works.

@Mike-MF Mike-MF marked this pull request as ready for review June 15, 2024 18:21
JoramD0
JoramD0 approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@JoramD0 JoramD0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dedicated environment with @Mike-MF and worked as designed.

jonpas
jonpas requested changes Jun 16, 2024
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does assigning curator still cause a temporary freeze?

addons/debug_console/XEH_postInit.sqf Outdated Show resolved Hide resolved
addons/debug_console/XEH_postInit.sqf Outdated Show resolved Hide resolved
@Mike-MF
Copy link
Member Author

Mike-MF commented Jun 16, 2024 •
edited
Loading

Does assigning curator still cause a temporary freeze?

Yes, but this one is very minor in comparison to the others. I tested it on Saturday and it was not noticeable for anyone else. (I asked)

@jonpas jonpas merged commit 8ff4c36 into master Jun 16, 2024
3 checks passed
@jonpas jonpas deleted the debug_console_expansion branch June 16, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoramD0 JoramD0 JoramD0 approved these changes

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Mike-MF @jonpas @JoramD0