Requeuer and Message Delay #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Aug 22, 2024
Co-authored-by: ccoVeille <[email protected]>
ccoVeille
reviewed
Aug 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #469 +/- ##
==========================================
- Coverage 73.55% 73.42% -0.13%
==========================================
Files 61 65 +4
Lines 3278 3424 +146
==========================================
+ Hits 2411 2514 +103
- Misses 715 746 +31
- Partials 152 164 +12 ☔ View full report in Codecov by Sentry. |
roblaszczak
reviewed
Oct 21, 2024
_examples/real-world-examples/delayed-requeue/docker-compose.yml
Outdated
Show resolved
Hide resolved
roblaszczak
reviewed
Oct 24, 2024
|
|
||
| ## Usage | ||
|
|
||
| Set the `DATABASE_URL` environment variable to your PostgreSQL connection string. |
There was a problem hiding this comment.
it would be nice to provide example one - they are 10 different formats and it's useful to have it
roblaszczak
reviewed
Oct 24, 2024
| @@ -0,0 +1,32 @@ | |||
| # pq | |||
There was a problem hiding this comment.
probably it would be nice to link here from poison queue godoc?
There was a problem hiding this comment.
Which one, though? The SQL one?
There was a problem hiding this comment.
Will add more docs in a follow-up PR.
m110
added a commit
to ThreeDotsLabs/watermill-sql
that referenced
this pull request
Oct 25, 2024
* Added `PostgreSQLQueueSchema` and `PostgreSQLQueueOffsetsAdapter`.
* This schema is similar to the original one, except it allows filtering messages with a custom `WHERE` clause.
* It doesn't support customer groups.
* It allows deleting messages from the table after acking (optional).
* Added `NewDelayedPostgreSQLPublisher` and `NewDelayedPostgresSQLSubscriber`
* They work on top of the conditional schema and use the `delay` component implemented in ThreeDotsLabs/watermill#469
* The idea is to receive messages with a delay or at a given time in a simple way.
* Reworked the `SchemaAdapter` and `OffsetsAdapter` interfaces **(Breaking change -> will bump the major to v4)**.
* We had a few instances where some details have been missing from one of the interface methods. It makes it difficult to extend this library with new features, as each will require a major version bump, and we want to avoid it if possible.
* To mitigate this, we're moving to a `params` struct passed to the methods instead of raw arguments. It adds some verbosity but allows extending the params if needed with no breaking changes to the library.
* The methods now also return errors.
* Migration: if you don't use a custom schema/offsets adapter, you don't need to do anything. If you do, change the methods to implement the new interfaces. Use values from the `params` argument and return errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requeuercomponent.delaycomponent to delay the forwarding.delaypackage. It contains helpers for setting delay metadata on messages.Requeuercomponent).pqCLI tool for working with poison queues.