Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a build-time litmus test for the arrow R package #128

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

eddelbuettel
Copy link
Contributor

Per a request of @johnkerl a quick test that the arrow R package loads and runs.

Copy link
Collaborator

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
Thanks @eddelbuettel !!!!!

@jdblischak this LGTM -- since this is a non-recipe PR, do we need to bump the build number in recipe/meta.yaml -- ?

@johnkerl johnkerl changed the title Add a build-time litmus test for the arrow R package Add a build-time litmus test for the arrow R package Apr 9, 2024
@johnkerl
Copy link
Collaborator

johnkerl commented Apr 9, 2024

CI fails are the same as for #127 and are independent of this PR.

@johnkerl
Copy link
Collaborator

johnkerl commented Apr 9, 2024

@jdblischak this LGTM -- since this is a non-recipe PR, do we need to bump the build number in recipe/meta.yaml -- ?

nvm -- I see as precedent #120 (comment)

@johnkerl johnkerl merged commit 2348b0a into main Apr 9, 2024
2 of 5 checks passed
@johnkerl johnkerl deleted the de/sc-44894/assert_arrow_loads branch April 9, 2024 20:24
@jdblischak
Copy link
Collaborator

since this is a non-recipe PR, do we need to bump the build number in recipe/meta.yaml -- ?

No, no need to bump the build number. It's not affecting the output binary in any way since it is only a diagnostic for help troubleshooting #126. You'd only need to bump the build number if the update to the build script did something like change a compiler flag

@johnkerl
Copy link
Collaborator

single-cell-data/TileDB-SOMA#2414

[sc-44854]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants