Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new test to achieve full coverage #157

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

clizbe
Copy link
Member

@clizbe clizbe commented Oct 18, 2023

Pull request details

Describe the changes made in this pull request

Added new test that includes non-silent validation check

List of related issues or pull requests

Closes #145

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@clizbe clizbe force-pushed the 145_test_coverage branch from b15ca1b to 23ad125 Compare October 18, 2023 12:18
Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@clizbe clizbe merged commit 92ea7e4 into TulipaEnergy:main Oct 18, 2023
4 checks passed
@clizbe clizbe deleted the 145_test_coverage branch October 18, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tests to make Codecov happy
2 participants