Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed benchmark "redefinition of constant" warning #189

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fixed benchmark "redefinition of constant" warning #189

merged 1 commit into from
Oct 25, 2023

Conversation

clizbe
Copy link
Member

@clizbe clizbe commented Oct 25, 2023

Pull request details

Describe the changes made in this pull request

Changed names of input and output folders for benchmark so fix Warnings.

List of related issues or pull requests

Closes #174

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

abelsiqueira
abelsiqueira approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@abelsiqueira abelsiqueira merged commit 147e42e into TulipaEnergy:main Oct 25, 2023
1 check passed
@clizbe clizbe deleted the 174_benchmark_folders branch October 26, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelsiqueira abelsiqueira abelsiqueira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input and output folders for the benchmark
2 participants
@clizbe @abelsiqueira