Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new data for a second representative period #194

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

datejada
Copy link
Member

@datejada datejada commented Oct 25, 2023

Pull request details

Describe the changes made in this pull request

Add new data for a second representative in the profiles and representative data

List of related issues or pull requests

Closes #181

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

@datejada datejada force-pushed the 181-add-second-rp-Norse branch from e60fcca to 04cc36a Compare October 25, 2023 14:57
@datejada datejada requested a review from gnawin October 25, 2023 15:04
@datejada datejada marked this pull request as ready for review October 25, 2023 15:04
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

Copy link
Member

@gnawin gnawin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it looks fine. There is now a conflict that you have to solve, after that it could be merged.

@datejada datejada force-pushed the 181-add-second-rp-Norse branch from 48ba205 to ede1d0a Compare October 26, 2023 06:50
@datejada datejada merged commit 1eaeec3 into TulipaEnergy:main Oct 26, 2023
4 checks passed
@datejada datejada deleted the 181-add-second-rp-Norse branch October 26, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a second representative period to Norse case
2 participants