Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove *_partitions from graph object #939

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

abelsiqueira
Copy link
Member

@abelsiqueira abelsiqueira commented Dec 3, 2024

Remove rep_periods_partitions and timeframe_partitions from graph assets and flows objects.
#610 is not necessary anymore after that.
In the future, this code might be useful for user-friendly input.

Blocked by #928

Closes #610

@abelsiqueira abelsiqueira changed the title 610 remove graph partitions Remove *_partitions from graph object Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (f7440b9) to head (eebec8b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #939      +/-   ##
==========================================
- Coverage   95.76%   91.42%   -4.34%     
==========================================
  Files          30       30              
  Lines        1110     1085      -25     
==========================================
- Hits         1063      992      -71     
- Misses         47       93      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abelsiqueira abelsiqueira force-pushed the 610-remove-graph-partitions branch from 954f60c to eebec8b Compare December 4, 2024 09:17
@abelsiqueira abelsiqueira marked this pull request as ready for review December 4, 2024 09:18
@abelsiqueira abelsiqueira added the benchmark PR only - Run benchmark on PR label Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Benchmark Results

f7440b9... eebec8b... f7440b9.../eebec8beb2338d...
energy_problem/create_model 41.3 ± 0.86 s 42.9 ± 1.5 s 0.963
energy_problem/input_and_constructor 15.1 ± 0.38 s 14.1 ± 0.3 s 1.07
time_to_load 3.94 ± 0.089 s 3.9 ± 0.011 s 1.01
f7440b9... eebec8b... f7440b9.../eebec8beb2338d...
energy_problem/create_model 0.664 G allocs: 21.1 GB 0.664 G allocs: 21.1 GB 1
energy_problem/input_and_constructor 0.0562 G allocs: 2.17 GB 0.043 G allocs: 1.67 GB 1.3
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. LTGM.

@abelsiqueira abelsiqueira merged commit f6b1613 into main Dec 4, 2024
6 of 8 checks passed
@abelsiqueira abelsiqueira deleted the 610-remove-graph-partitions branch December 4, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark PR only - Run benchmark on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve _parse_rp_partitions to reflect more general usage
2 participants