Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove first row of input files #993

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

datejada
Copy link
Member

Remove the first row that is not being used in the model.

Related issues

Closes #991

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

@datejada
Copy link
Member Author

@abelsiqueira and @suvayu This PR attempts to remove the first row of the input files as we discussed. To make it work we need to change the defaults in TulipaIO here:

https://github.com/TulipaEnergy/TulipaIO.jl/blob/6bc433b0c087ff1ae3d0806078445817c4eb56d6/src/pipeline.jl#L9

The easy/fast solution is to change the values in TulipaIO and rerelease them. But, maybe there is a more robust way for possible future changes. I created the issue anyway for TulipaIO:

TulipaEnergy/TulipaIO.jl#85

What do you think is the best way to go forward?

Thanks!

@suvayu
Copy link
Member

suvayu commented Jan 10, 2025

I consider the way defaults are set in TIO temporary, so anything that removes them is very welcome.

@abelsiqueira
Copy link
Member

New release of TulipaIO is the way to go, in my opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove first row from the input files
3 participants