Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use feature testing to find alloca() #285

Closed
wants to merge 2 commits into from
Closed

use feature testing to find alloca() #285

wants to merge 2 commits into from

Conversation

guijan
Copy link
Contributor

@guijan guijan commented Jan 14, 2025

Fixes compilation on OpenBSD and possibly other systems.

arch1t3cht
arch1t3cht reviewed Jan 14, 2025
View reviewed changes
src/MatroskaParser.c Outdated Show resolved Hide resolved
src/MatroskaParser.c Outdated Show resolved Hide resolved
src/meson.build Outdated Show resolved Hide resolved
src/meson.build Outdated Show resolved Hide resolved
@guijan
use feature testing to find alloca()
82ce861 
Fixes compilation on OpenBSD and possibly other systems.
@guijan
Copy link
Contributor Author

guijan commented Jan 14, 2025

Let me work on this more because this is harder than it looks, although the original mistakes were basic.
In MSVC _alloca() is an intrinsic and cc.has_function can't find it.
In clang-cl it's something else and the code that works with MSVC breaks there.

@guijan guijan closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arch1t3cht arch1t3cht arch1t3cht left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guijan @arch1t3cht