Improved Chat / Transcript Virtualization #1088
Draft
+2,434
−908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonstyle
force-pushed
the
feature/json-perf
branch
6 times, most recently
from
e62cd77 to
8405557
Compare
Use a transferableObject to provide the string contents to the web worked to avoid string copying. Very noticeably faster for large json strings. Json tweak
Some key things: - The virtual lists don’t perform well with margins along the direction of scrolling (due to size computation), so wrap element in a container with padding to provide margins. - Adjust css to account for above - Use the current scrollable region as the scroll parent when computing whether to render items. This required gettings refs from the top level down to the transcript view.l - Overscan is used to reduce jank in scrolling is items are rendered and their size is computed.
This moves it up, but we’d eventually like to get it all the way to the top of the stack (in some kind of sample specific state bag).
Correct whitespace
dragonstyle
force-pushed
the
feature/json-perf
branch
from
8405557 to
9509598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massive improvement in log viewer performance for large samples. This has a few changes:
After experimenting with react-window, react-virtualized, and virtuoso, I ended up extending our own virtual list to support dynamic heights and custom scroll parents (the two features we really needed to make this work).
There can be some scroll jitter at very high speed scroll (especially when there is slow loading content like images) as the heights of rows are being computed on the fly. Will experiment with a cache to remedy this.
This PR contains:
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: