Resolved Review comments AB#107519

UKHO · Jan 11, 2024 · da01d2a · da01d2a
1 parent da80e02
commit da01d2a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/tests/UKHO.ERPFacade.API.FunctionalTests/FunctionalTests/RoSWebhookScenarios.cs b/tests/UKHO.ERPFacade.API.FunctionalTests/FunctionalTests/RoSWebhookScenarios.cs
@@ -75,7 +75,7 @@ public async Task WhenValidRoSEventInRecordOfSalePublishedEventPostReceivedWithI
         [Test, Order(2)]
         [TestCase("LTC03_InValidLTCwithNoCorrelationID.json", TestName = "WhenValidRoSMigrateNewLicencePublishedEventReceivedWithInvalidPayload_ThenWebhookReturns400BadRequestResponse")]
         [TestCase("LTC05_InValidLTCwithNoCorrelationID.json", TestName = "WhenValidRoSMigrateExistingLicencePublishedEventReceivedWithInvalidPayload_ThenWebhookReturns400BadRequestResponse")]
-        [TestCase("LTC09_InValidLTCwithNoCorrelationID.json", TestName = "WhenValidRoSConvertTrialToFullLicencePublishedEventReceivedWithInvalidPayload_ThenWebhookReturns400BadRequestResponse")]
+        [TestCase("LTC09_InvalidLTCwithNoCorrelationID.json", TestName = "WhenValidRoSConvertTrialToFullLicencePublishedEventReceivedWithInvalidPayload_ThenWebhookReturns400BadRequestResponse")]
         [TestCase("RoS11_InValidRoSwithNoCorrelationID.json", TestName = "WhenInValidRoSEventInRecordOfSalePublishedEventPostReceived_ThenWebhookReturns400BadRequestResponse")]
         public async Task WhenInValidRoSEventInRecordOfSalePublishedEventPostReceived_ThenWebhookReturns400BadRequestResponse(string payloadFileName)
         {

diff --git a/tests/UKHO.ERPFacade.API.FunctionalTests/Service/RoSWebhookEndpoint.cs b/tests/UKHO.ERPFacade.API.FunctionalTests/Service/RoSWebhookEndpoint.cs
@@ -14,7 +14,7 @@ public class RoSWebhookEndpoint
         private readonly AzureBlobStorageHelper _azureBlobStorageHelper;
         private const string RoSWebhookRequestEndPoint = "/webhook/recordofsalepublishedeventreceived";
         public static string GeneratedCorrelationId = string.Empty;
-        public static string RecordOfSalesContainerName = "recordofsaleblobs";
+        public const string RecordOfSalesContainerName = "recordofsaleblobs";
 
         public RoSWebhookEndpoint()
         {

diff --git a/tests/UKHO.ERPFacade.API.FunctionalTests/UKHO.ERPFacade.API.FunctionalTests.csproj b/tests/UKHO.ERPFacade.API.FunctionalTests/UKHO.ERPFacade.API.FunctionalTests.csproj
@@ -188,7 +188,7 @@
     <None Update="ERPFacadePayloadTestData\RoSPayloadTestData\LTC08_InvalidRoSConvertTrialToFullLicence.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
-    <None Update="ERPFacadePayloadTestData\RoSPayloadTestData\LTC09_InValidLTCwithNoCorrelationID.json">
+    <None Update="ERPFacadePayloadTestData\RoSPayloadTestData\LTC09_InvalidLTCwithNoCorrelationID.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
     <None Update="ERPFacadePayloadTestData\RoSPayloadTestData\RoS13_ValidLastPayloadForMerging.json">